SqlConnectionPool does not invoke PoolMetrics begin/end methods #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdickmeiss
force-pushed
the
sql-connection-pool-in-use-metrics
branch
from
3d71a14 to
b46ec6d
Compare
vietj
previously requested changes
Nov 10, 2025
Member
vietj
left a comment
vietj
left a comment
There was a problem hiding this comment.
Can you contribute a test for this ?
adamdickmeiss
force-pushed
the
sql-connection-pool-in-use-metrics
branch
from
7c43127 to
b46ec6d
Compare
Begin/End metrics size depends on the timeout parameter value. When a timeout is expected, a single begin/end metric should be listed, corresponding to the getConnection/close calls wrapping the tasks. When a timeout isn't expected, the number of begin/end metric is the number of tasks plus one, corresponding to the getConnection/close calls. Signed-off-by: Thomas Segismont <[email protected]>
Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
changed the title
Since metricsEnd can be invoked asynchronously, relax the test of usage size. Signed-off-by: Thomas Segismont <[email protected]>
Contributor
|
Thank you @adamdickmeiss |
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vert-x3/vertx-micrometer-metrics#278